[PATCH] D30225: [LIR] re-enable generation of memmove with runtime checks

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1111
+  if (Instruction *In = dyn_cast<Instruction>(NumBytes))
+    if (Value *Simp = SimplifyInstruction(In, *DL, TLI, DT))
+      NumBytes = Simp;
----------------
efriedma wrote:
> Why do we need to call SimplifyInstruction here?
I guess back when this was written, it made some difference.  I don't remember what it was though.  Do you think it's unnecessary now?


Repository:
  rL LLVM

https://reviews.llvm.org/D30225