[llvm] r296253 - [DebugInfo] Skip implicit_const attributes when dumping .debug_info. NFC.

[Eric Christopher via llvm-commits]

On Mon, Feb 27, 2017 at 11:47 AM Adrian Prantl <aprantl at apple.com> wrote:

>
> > On Feb 27, 2017, at 11:13 AM, David Blaikie <dblaikie at gmail.com> wrote:
> >
> > I tend to think it's more legible if we include the values there, even
> if no bytes were required to produce them. I don't generally look at the
> abbreviations when reading a dump & expect to see the data in the
> debug_info/debug_types output.
>
> I'm pretty sure we want the implicit attributes to show up in the dump
> (perhaps with a comment that they are implicit in the abbreviation where we
> normally show [DW_FORM...] in the output.
>
> Tools like llvm-dwarfdump are used by different audiences. Eventually we
> probably want something like a --brief mode (that could even be the default
> like in Darwin's dwarfdump) that just shows the high-level contents of the
> debug_info section without all the low-level details like forms and
> abbreviations, and then we could have a verbose mode that shows the actual
> encoding of the data. Personally, most of the times I'm using dwarfdump I
> typically don't care about how an attribute was encoded.
>
>
> Side note: I don't think that this commit was really NFC.
>

This is most assuredly not NFC. It changes the output of text so it's
definitely "functional".

-eric


>
> -- adrian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170227/c9b0666c/attachment.html>