[PATCH] D27527: Process tilde in llvm::sys::path::native.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Seems like reasonable functionality. I just have a few comments on the unittest. If SmallString doesn't do operator==, they're mostly irrelevant.



================
Comment at: unittests/Support/Path.cpp:951-953
+  EXPECT_TRUE(Path7.endswith("\\aaa"));
+  EXPECT_TRUE(Path7.startswith(PathHome));
+  EXPECT_EQ(Path7.size(), PathHome.size() + strlen(Path7a + 1));
----------------
Does this simplify to `EXPECT_EQ(Path7, PathHome + "\\aaa")`? If so we don't need the const char * local.


================
Comment at: unittests/Support/Path.cpp:958
+  path::native(Path8);
+  EXPECT_TRUE(Path8.equals(PathHome));
+
----------------
Does EXPECT_EQ work?


https://reviews.llvm.org/D27527