[PATCH] D30062: Estimate speedup due to inlining and use that to adjust threshold.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 26 17:10:14 PST 2017


chandlerc added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:532
+    bool SVLookup = false;
+    for (User::op_iterator I = GEP.idx_begin(), E = GEP.idx_end(); I != E;
+         ++I) {
----------------
Prazek wrote:
> chandlerc wrote:
> > Prazek wrote:
> > > range based for loop? There should be something like .operands()
> > I looked and there isn't really. I can add one though.
> That would be great, thanks
Huh, I must have missed it. Danny added an 'indices' method back in 2015. =D


https://reviews.llvm.org/D30062





More information about the llvm-commits mailing list