[PATCH] D29897: [BypassSlowDivision] Use ValueTracking to simplify run-time checks

Nikolai Bozhenov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 26 13:12:06 PST 2017


n.bozhenov updated this revision to Diff 89816.
n.bozhenov added a comment.
Herald added a subscriber: jholewinski.

Ok. I see your point. Indeed, for example, there's no need to run the whole X86 code generator to check that a division bypassing is disabled if one of the operands doesn't fit into BypassType. So I have moved the tests introduced by this patch into Transforms/CodeGenPrepare/NVPTX/bypass-slow-div-special-cases.ll. However, I still believe that we should keep a few existing tests in CodeGen/X86/bypass-slow-division-64.ll to check that when bypassing fires, it produces a good X86 code.


https://reviews.llvm.org/D29897

Files:
  lib/Transforms/Utils/BypassSlowDivision.cpp
  test/Transforms/CodeGenPrepare/NVPTX/bypass-slow-div-special-cases.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29897.89816.patch
Type: text/x-patch
Size: 11908 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170226/88f56391/attachment.bin>


More information about the llvm-commits mailing list