[PATCH] D29845: [SelectionDAG] Remove redundant stores more aggressively.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 25 14:33:57 PST 2017


efriedma added a comment.

> Are there other cases that you've noticed?

I originally stumbled across this issue looking at code with a construct like i24_insert_bit... I don't know if this comes up in practice otherwise.

> x, ch1 = Load A, ch0
>  ch2 = Store volatile AliasA x+1 ch1
>  y, ch3 = Load A ch2
>  ch4 = TF ch1, ch3
>  ch5 = Store A x ch4

This is the reason I added the hasOneUse check.


Repository:
  rL LLVM

https://reviews.llvm.org/D29845





More information about the llvm-commits mailing list