[PATCH] D30357: [ObjectYAML] Add ability for DWARFYAML to calculate DIE lengths

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 15:24:11 PST 2017


aprantl added a comment.

It would be good to split this into an NFC patch that just moves stuff around and then a small commit+testcase for the new functionality. This makes reviewing easier & faster.



================
Comment at: lib/ObjectYAML/DWARFEmitter.cpp:117
+// correctly. This allows DIEs to be specified without a lenght or with an
+// an incorrect length.
+class DIEFixupVisitor : public DWARFYAML::Visitor {
----------------
Doxygenify all comments?


https://reviews.llvm.org/D30357





More information about the llvm-commits mailing list