[PATCH] D29092: PR31729: [GVNHoist] Don't hoist unsafe scalars at -Oz

[David Majnemer via Phabricator via llvm-commits]

majnemer added a comment.

In https://reviews.llvm.org/D29092#686255, @hans wrote:

> While the `if (OptForMinSize && isSafeToSpeculativelyExecute(I))` fix doesn't look great, and the discussion suggests there might be more fundamental problems with GVNHoist, at least this seems like a good stop-gap fix for 4.0.
>
> If I understand correctly, the impact will be some compile-time reduction at `-Oz`, less hoisting, and more correctness.


Honestly, I'm not sure I agree. I think the safer thing to do would be to rip out the OptForMinSize handling from the 4.0 release.


https://reviews.llvm.org/D29092