[PATCH] D30349: [AMDGPU] Runtime metadata fixes:

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 13:39:34 PST 2017


kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, tony-tye, nhaehnle, wdng.

1. Verify that runtime metadata is actually valid runtime metadata when assembling, otherwise we could accept the following when assembling, but ocl runtime will reject it:

  .amdgpu_runtime_metadata
  { amd.MDVersion: [ 2, 1 ], amd.RandomUnknownKey, amd.IsaInfo:



2. Make IsaInfo optional, and always emit it.


https://reviews.llvm.org/D30349

Files:
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPURuntimeMD.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPURuntimeMD.h
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
  test/MC/AMDGPU/hsa.s
  test/MC/AMDGPU/metadata.s
  test/MC/AMDGPU/runtime-metadata-1.s
  test/MC/AMDGPU/runtime-metadata-2.s
  test/MC/AMDGPU/runtime-metadata-invalid-1.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30349.89716.patch
Type: text/x-patch
Size: 30283 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170224/bb7d1d2e/attachment.bin>


More information about the llvm-commits mailing list