[PATCH] D30136: [compiler-rt][builtins][WIP] Add _IsOSVersionAtLeast, to be used by ObjC's @available

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 12:56:16 PST 2017

erik.pilkington updated this revision to Diff 89710.
erik.pilkington marked 4 inline comments as done.
erik.pilkington added a comment.

This new patch addresses Alex's comments:

- Add more failure checks
- Rename `_IsOSVersionAtLeast` -> `__isOSVersionAtLeast`


- fall back to the function `CFPropertyListCreateFromXMLData` if `CFPropertyListCreateWithData` is unavailable.

@arphaman: As far as adding a test to test/builtins/Unit, I would like to but I don't know how these tests are run. I went through my trouble with it in the description above. Do you know how these tests are run?

Thanks for taking a look!



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30136.89710.patch
Type: text/x-patch
Size: 4159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170224/d31eace2/attachment.bin>

More information about the llvm-commits mailing list