[PATCH] D30344: [MemorySSA] Add OptimizeUses flag

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 11:39:51 PST 2017


Prazek added a comment.



In https://reviews.llvm.org/D30344#686029, @dberlin wrote:

> Could you explain the issue with optimizing uses that is making it hard to write tests?
>  I mean, at worst we could add a protected constructor, but i'd like to understand the underlying issue first.


I would like to make the walker smart enough to optimize invariant.group as good as in OptimizeUses.
If invariant.group attributest will be set before buildin mssa, then it will be optimized by UseOptimizer 
The only way to test it right now is either:

- create loads/stores, setup memory ssa, add invariant.group
- setup mssa, start adding new stores and loads with invariant.group


https://reviews.llvm.org/D30344





More information about the llvm-commits mailing list