[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2870
+
+  if (N->getOpcode() != ISD::VSELECT || Cond->getOpcode() != ISD::SETCC)
+    return SDValue();
----------------
jonpa wrote:
> efriedma wrote:
> > I still don't like that you're special-casing SETCC here... it isn't the only source of i1 vectors.
> If there is anything that really should be handled and commited at the same as the SETCC, please give more details.
> 
It would be nice to handle VSELECT(AND(SETCC, SETCC), X, Y).  I can't think of anything else that's likely to come up frequently.


https://reviews.llvm.org/D29489