getOperandsScalarizationOverhead()

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 04:38:47 PST 2017


Hi Hal,

 >> while writing CostModel tests for SystemZ, I needed to fix 
getOperandsScalarizationOverhead() so that it can handle vector argument 
types.
 > Why? (A test case would help).

Sorry I didn't mention it more clearly, but this patch will go in 
together with the SystemZ cost functions patch, where the CostModel 
tests have also been added. They don't work without this patch (bar the 
check for Undef, which is just an improvement). CostModel will make a 
call with vector arguments, which ends up here in common code. 
https://reviews.llvm.org/D29631#fb86bef3

It would be great to get that patch approved (SystemZ parts are already 
approved), and then commit these two together, but if you wish I could 
perhaps merge this smaller patch into it?

>
> +        Type *VecTy = nullptr;
>
> Don't default initialize here (it is not needed).
>
> +        }
> +        else
>
> else on the previous line with the }.
fixed.

Thanks,

Jonas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: getOpScalOH_vector_args.patch
Type: text/x-patch
Size: 919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170224/4443ecc9/attachment.bin>


More information about the llvm-commits mailing list