[PATCH] D30258: [ELF] - Implemented --no-dynamic-linker option

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Options.td:152
+def no_dynamic_linker: F<"no-dynamic-linker">;
+
 def no_export_dynamic: F<"no-export-dynamic">;
----------------
grimar wrote:
> ruiu wrote:
> > Remove this blank line to keep the style consistent.
> Blank line is intentional. Doesn't absence of blank line here
> 
> ```
> def no_export_dynamic: F<"no-export-dynamic">;
> def no_fatal_warnings: F<"no-fatal-warnings">;
> ```
> 
> is a violation of style ? I think for regular options (not aliases and not ignored)
> we always used blank line to separate them.
Looks like these two options have no empty separating line because does not
have HelpText ? That is inconsistent styling then.
At least because LTO options has HelpText but also have no blank lines.

I think it worth to add help text for all options that are active (not ignored).
For ignored options probably makes sence to put "Option is ignored" or something 
as help text too.

I added HelpText for no_dynamic_linker before commiting.


Repository:
  rL LLVM

https://reviews.llvm.org/D30258