[PATCH] D26872: Outliner: Add MIR-level outlining pass

Jessica Paquette via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 17:04:57 PST 2017


Yes; I’m working on the patch right now. I am pretty close to having it working, so I can fix it up first.

> On Feb 23, 2017, at 5:01 PM, Adrian Prantl <aprantl at apple.com> wrote:
> 
> 
>> On Feb 23, 2017, at 4:18 PM, Matthias Braun via Phabricator <reviews at reviews.llvm.org> wrote:
>> 
>> MatzeB accepted this revision.
>> MatzeB added a comment.
>> This revision is now accepted and ready to land.
>> 
>> Thanks for pushing this, this is coming along nicely!
>> 
>> At this point I don't see any correctness or compiletime problems (with the comments below addressed).
> 
> Just to make sure this doesn't get lost, there *is* a correctness bug with how DBG_VALUEs are handled. (See my comment on line 10412). It would be good to get this fixed before committing.
> 
> -- adrian
> 
>> Let's commit this and keep improving it in-tree. This should also make reviewing easier as we can have smaller follow-up patches.
>> 
> 



More information about the llvm-commits mailing list