[PATCH] D29092: PR31729: [GVNHoist] Don't hoist unsafe scalars at -Oz

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D29092#685256, @hiraditya wrote:

> In https://reviews.llvm.org/D29092#685046, @mehdi_amini wrote:
>
> > I'd add also that `isSafeToSpeculativelyExecute` may be conservative right now, but it should improve with https://reviews.llvm.org/D20116
> >  So it is even unclear to me which cases GVN hoist would be able to catch that are not in the realm of  `isSafeToSpeculativelyExecute`.
>
>
> Currently `isSafeToSpeculativelyExecute` returns false for Calls, stores. GVN Hoist will hoist them if it is legal to do so.


Can you address everything of what I wrote please instead of repeating partially what I wrote? I don't feel we'll make progress here.


https://reviews.llvm.org/D29092