[PATCH] D30314: Implement some methods for NativeRawSymbol

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth marked 3 inline comments as done.
amccarth added a comment.

Thanks for the tips on how to handle the Expected.  From the description, I had the impression that it was only necessary to check for the error.



================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h:24-26
+  NativeSession(StringRef Path,
+                std::unique_ptr<PDBFile> PdbFile,
                 std::unique_ptr<BumpPtrAllocator> Allocator);
----------------
zturner wrote:
> Is the `Path` here necessary?`  The `PDBFile` class is constructed with a Path, and you can query it via `getFilePath()`.
Now that I've re-based I see it.  Done.


https://reviews.llvm.org/D30314