[PATCH] D30081: [PPC] Eliminate more compare instructions using record-form operation

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 14:49:39 PST 2017


nemanjai added a comment.

In https://reviews.llvm.org/D30081#684391, @inouehrs wrote:

> Thank you for the comment.
>  As you said, I did not confirm the cases for added opcodes other than `andi.`. So I will remove them.
>  I thought it is safe since they are aliases for special cases of `rlwinm`, which is already included as a target of optimization.


They may very well be safe. In fact, I assume they are since I'm sure you've run fairly thorough testing with this patch. But it would be good to understand the impact and try to write test cases that exercise these.


https://reviews.llvm.org/D30081





More information about the llvm-commits mailing list