[PATCH] D30307: Fix insertion of `sanitizer_cov_trace_pc_guard` insertion in optimized code with debug info

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 13:07:55 PST 2017


> On Feb 23, 2017, at 12:54 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> 
> On Thu, Feb 23, 2017 at 12:04 PM, Mehdi AMINI via Phabricator via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> mehdi_amini created this revision.
> Herald added a subscriber: aprantl.
> 
> It is illegal to have a call without debug info attached in a function
> with debug info: it'll crash the backend.
> 
> Isn't that a bug in the backend? What happens if I inline a function compiled without debug info into a function compiled with debug info?

See my update, this is in the verifier.
However I agree with you that this seems suspicious: what if LTO or ThinLTO make available a definition without debug info into a file with debug info. 

CC Adrian to clarify?

— 
Mehdi


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170223/e6768991/attachment.html>


More information about the llvm-commits mailing list