[llvm] r295930 - [X86][IR] In AutoUpgrade, check explicitly for xop.vpcmov and xop.vpcmov.256 instead of anything starting with xop.vpcmov

[Robinson, Paul via llvm-commits]

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Craig Topper via llvm-commits
> Sent: Wednesday, February 22, 2017 7:22 PM
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r295930 - [X86][IR] In AutoUpgrade, check explicitly for
> xop.vpcmov and xop.vpcmov.256 instead of anything starting with xop.vpcmov
> 
> Author: ctopper
> Date: Wed Feb 22 21:22:14 2017
> New Revision: 295930
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=295930&view=rev
> Log:
> [X86][IR] In AutoUpgrade, check explicitly for xop.vpcmov and
> xop.vpcmov.256 instead of anything starting with xop.vpcmov
> 
> There were some older intrinsics that only existed for less than a month
> in 2012 that still exist in some out of tree test files that start with
> this string, but aren't able to be handled by the current upgrade code and
> fire an assert. Now we'll go back to treating them as not intrinsics at
> all and just passing them through to output.
> 
> Fixes PR32041, sort of.
> 
> Modified:
>     llvm/trunk/lib/IR/AutoUpgrade.cpp
> 
> Modified: llvm/trunk/lib/IR/AutoUpgrade.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/lib/IR/AutoUpgrade.cpp?rev=295930&r1=295929&r2=295930&v
> iew=diff
> ==========================================================================
> ====
> --- llvm/trunk/lib/IR/AutoUpgrade.cpp (original)
> +++ llvm/trunk/lib/IR/AutoUpgrade.cpp Wed Feb 22 21:22:14 2017
> @@ -230,7 +230,8 @@ static bool ShouldUpgradeX86Intrinsic(Fu
>        Name.startswith("avx2.pblendd.") || // Added in 3.7
>        Name.startswith("avx.vbroadcastf128") || // Added in 4.0
>        Name == "avx2.vbroadcasti128" || // Added in 3.7
> -      Name.startswith("xop.vpcmov") || // Added in 3.8
> +      Name == "xop.vpcmov" || // Added in 3.8
> +      Name == "xop.vpcmov.256" || // Added in 4.1

Shouldn't that be 5.0 not 4.1?
--paulr

>        Name.startswith("avx512.mask.move.s") || // Added in 4.0
>        (Name.startswith("xop.vpcom") && // Added in 3.2
>         F->arg_size() == 2))
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits