[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 12:29:06 PST 2017


efriedma added a comment.

ARM and x86 test changes look fine.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2870
+
+  if (N->getOpcode() != ISD::VSELECT || Cond->getOpcode() != ISD::SETCC)
+    return SDValue();
----------------
I still don't like that you're special-casing SETCC here... it isn't the only source of i1 vectors.


https://reviews.llvm.org/D29489





More information about the llvm-commits mailing list