[PATCH] D29023: [Stack Protection] Add diagnostic information for why stack protection was applied to a function

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 03:36:13 PST 2017


jhenderson updated this revision to Diff 89491.
jhenderson added a comment.

Thanks, I've updated accordingly. I also added a test case to check that the remark is not emitted if the switch isn't specified.

I had to constify an argument to one of the OptimizationRemarkEmitter::emitOptimizationRemark overloads, since it was missing. I'm happy to add const to the others as appropriate as well, but that's probably a different change.


https://reviews.llvm.org/D29023

Files:
  include/llvm/Analysis/OptimizationDiagnosticInfo.h
  lib/CodeGen/StackProtector.cpp
  test/CodeGen/X86/stack-protector-remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29023.89491.patch
Type: text/x-patch
Size: 7396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170223/18a025d2/attachment.bin>


More information about the llvm-commits mailing list