[lld] r295939 - Update comment: .note.GNU-stack is added by default today.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 23:15:47 PST 2017


Author: ruiu
Date: Thu Feb 23 01:15:46 2017
New Revision: 295939

URL: http://llvm.org/viewvc/llvm-project?rev=295939&view=rev
Log:
Update comment: .note.GNU-stack is added by default today.

Modified:
    lld/trunk/ELF/InputFiles.cpp

Modified: lld/trunk/ELF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=295939&r1=295938&r2=295939&view=diff
==============================================================================
--- lld/trunk/ELF/InputFiles.cpp (original)
+++ lld/trunk/ELF/InputFiles.cpp Thu Feb 23 01:15:46 2017
@@ -418,11 +418,12 @@ elf::ObjectFile<ELFT>::createInputSectio
   // that the code in the object file does not expect that the stack is
   // executable (in terms of NX bit). If all input files have the marker,
   // the GNU linker adds a PT_GNU_STACK segment to tells the loader to
-  // make the stack non-executable.
+  // make the stack non-executable. Most object files have this section as
+  // of 2017.
   //
   // But making the stack non-executable is a norm today for security
-  // reasons (as of 2017). Failure to do so may result in a serious
-  // security issue. Therefore, LLD always adds PT_GNU_STACK unless it is
+  // reasons. Failure to do so may result in a serious security issue.
+  // Therefore, we make LLD always add PT_GNU_STACK unless it is
   // explicitly told to do otherwise (by -z execstack). Because the stack
   // executable-ness is controlled solely by command line options,
   // .note.GNU-stack sections are simply ignored.




More information about the llvm-commits mailing list