[PATCH] D30107: Make DynamicLibrary::getPermanentLibrary have a defined ordering.

Frederich Munch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 18:04:59 PST 2017


marsupial added inline comments.


================
Comment at: lib/Support/DynamicLibrary.cpp:57
+  std::vector<void*> Handles;
+  bool KeepFront;
+public:
----------------
marsupial wrote:
> vsk wrote:
> > Instead of having a 'KeepFront' switch, do you think it might be more convenient to store the RTLD_DEFAULT/IsProcess handle separately from the rest of the handles?
> Seems reasonable. Hopefully I haven't already tried that and there is a reason not...
Ohh thats right..it complicates the iterator interface!


https://reviews.llvm.org/D30107





More information about the llvm-commits mailing list