[PATCH] D27900: [ELF] - Keep the source file/line location information separate from the object file location information.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 14:00:57 PST 2017


ruiu added a comment.

I don't understand why need "note:" labels in so many places. Why don't you just make error messages multi-line? I don't think there's no such rule that you need to put "note:" after every "\n".

In addition to that, calling error() more than once for one error is not good. That function should be called exactly once for one error.


https://reviews.llvm.org/D27900





More information about the llvm-commits mailing list