[PATCH] D29897: [BypassSlowDivision] Use ValueTracking to simplify run-time checks

Nikolai Bozhenov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 12:49:18 PST 2017


n.bozhenov added a comment.

As for tests, it was discussed in https://reviews.llvm.org/D28196 that it's better to have them that detailed. I agree with you that they are overly fragile and check for a lot of actually insignificant details. But on the other hand, this approach also has a number of advantages: tests indeed guarantee that the compiler generates correct code for the testcase, the tests are easy to create and update, diffs in tests induced by patches are explicit and easy to review.


https://reviews.llvm.org/D29897





More information about the llvm-commits mailing list