[PATCH] D30266: Move Stream code from MSF -> Support

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
Herald added a subscriber: mgorny.

1. Move to Support
2. Rename classes to prefix everything with `Binary`
3. Add lots of unittests
4. Add lots of doxygen comments.

http://lists.llvm.org/pipermail/llvm-dev/2017-February/110342.html


https://reviews.llvm.org/D30266

Files:
  lld/COFF/PDB.cpp
  llvm/include/llvm/ADT/ArrayRef.h
  llvm/include/llvm/DebugInfo/CodeView/CVRecord.h
  llvm/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h
  llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h
  llvm/include/llvm/DebugInfo/CodeView/ModuleSubstream.h
  llvm/include/llvm/DebugInfo/CodeView/ModuleSubstreamVisitor.h
  llvm/include/llvm/DebugInfo/CodeView/RecordSerialization.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolDeserializer.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolRecord.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolRecordMapping.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolSerializer.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolVisitorDelegate.h
  llvm/include/llvm/DebugInfo/CodeView/TypeDeserializer.h
  llvm/include/llvm/DebugInfo/CodeView/TypeRecord.h
  llvm/include/llvm/DebugInfo/CodeView/TypeRecordMapping.h
  llvm/include/llvm/DebugInfo/CodeView/TypeSerializer.h
  llvm/include/llvm/DebugInfo/MSF/ByteStream.h
  llvm/include/llvm/DebugInfo/MSF/MappedBlockStream.h
  llvm/include/llvm/DebugInfo/MSF/SequencedItemStream.h
  llvm/include/llvm/DebugInfo/MSF/StreamArray.h
  llvm/include/llvm/DebugInfo/MSF/StreamInterface.h
  llvm/include/llvm/DebugInfo/MSF/StreamReader.h
  llvm/include/llvm/DebugInfo/MSF/StreamRef.h
  llvm/include/llvm/DebugInfo/MSF/StreamWriter.h
  llvm/include/llvm/DebugInfo/PDB/Native/DbiStream.h
  llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/GlobalsStream.h
  llvm/include/llvm/DebugInfo/PDB/Native/HashTable.h
  llvm/include/llvm/DebugInfo/PDB/Native/InfoStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/ModInfo.h
  llvm/include/llvm/DebugInfo/PDB/Native/ModStream.h
  llvm/include/llvm/DebugInfo/PDB/Native/NamedStreamMap.h
  llvm/include/llvm/DebugInfo/PDB/Native/PDBFile.h
  llvm/include/llvm/DebugInfo/PDB/Native/PublicsStream.h
  llvm/include/llvm/DebugInfo/PDB/Native/StringTable.h
  llvm/include/llvm/DebugInfo/PDB/Native/StringTableBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/TpiHashing.h
  llvm/include/llvm/DebugInfo/PDB/Native/TpiStream.h
  llvm/include/llvm/DebugInfo/PDB/Native/TpiStreamBuilder.h
  llvm/include/llvm/Support/BinaryByteStream.h
  llvm/include/llvm/Support/BinaryItemStream.h
  llvm/include/llvm/Support/BinaryStream.h
  llvm/include/llvm/Support/BinaryStreamArray.h
  llvm/include/llvm/Support/BinaryStreamReader.h
  llvm/include/llvm/Support/BinaryStreamRef.h
  llvm/include/llvm/Support/BinaryStreamWriter.h
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/DebugInfo/CodeView/CVSymbolVisitor.cpp
  llvm/lib/DebugInfo/CodeView/CVTypeDumper.cpp
  llvm/lib/DebugInfo/CodeView/CVTypeVisitor.cpp
  llvm/lib/DebugInfo/CodeView/CodeViewRecordIO.cpp
  llvm/lib/DebugInfo/CodeView/ModuleSubstream.cpp
  llvm/lib/DebugInfo/CodeView/ModuleSubstreamVisitor.cpp
  llvm/lib/DebugInfo/CodeView/RecordSerialization.cpp
  llvm/lib/DebugInfo/CodeView/TypeDumpVisitor.cpp
  llvm/lib/DebugInfo/CodeView/TypeRecord.cpp
  llvm/lib/DebugInfo/CodeView/TypeSerializer.cpp
  llvm/lib/DebugInfo/MSF/CMakeLists.txt
  llvm/lib/DebugInfo/MSF/MappedBlockStream.cpp
  llvm/lib/DebugInfo/MSF/StreamReader.cpp
  llvm/lib/DebugInfo/MSF/StreamWriter.cpp
  llvm/lib/DebugInfo/PDB/Native/DbiStream.cpp
  llvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/GSI.cpp
  llvm/lib/DebugInfo/PDB/Native/GSI.h
  llvm/lib/DebugInfo/PDB/Native/GlobalsStream.cpp
  llvm/lib/DebugInfo/PDB/Native/HashTable.cpp
  llvm/lib/DebugInfo/PDB/Native/InfoStream.cpp
  llvm/lib/DebugInfo/PDB/Native/InfoStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/ModInfo.cpp
  llvm/lib/DebugInfo/PDB/Native/ModStream.cpp
  llvm/lib/DebugInfo/PDB/Native/NamedStreamMap.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
  llvm/lib/DebugInfo/PDB/Native/PDBFile.cpp
  llvm/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/PublicsStream.cpp
  llvm/lib/DebugInfo/PDB/Native/StringTable.cpp
  llvm/lib/DebugInfo/PDB/Native/StringTableBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/SymbolStream.cpp
  llvm/lib/DebugInfo/PDB/Native/TpiStream.cpp
  llvm/lib/DebugInfo/PDB/Native/TpiStreamBuilder.cpp
  llvm/lib/Support/BinaryStreamReader.cpp
  llvm/lib/Support/BinaryStreamWriter.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
  llvm/tools/llvm-pdbdump/YamlTypeDumper.cpp
  llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp
  llvm/tools/llvm-readobj/COFFDumper.cpp
  llvm/unittests/DebugInfo/PDB/HashTableTest.cpp
  llvm/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp
  llvm/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp
  llvm/unittests/Support/BinaryStreamTest.cpp
  llvm/unittests/Support/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30266.89396.patch
Type: text/x-patch
Size: 245230 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170222/91bd8dee/attachment-0001.bin>