[PATCH] D30264: Add MCContext argument to MCAsmBackend::applyFixup for error reporting

[Alex Bradbury via Phabricator via llvm-commits]

asb created this revision.
Herald added subscribers: nhaehnle, nemanjai, jyknight, arsenm, aemerson.
Herald added a reviewer: javed.absar.

A number of backends (AArch64, MIPS, ARM) have been using MCContext::reportError to report issues such as out-of-range fixup values in their TgtAsmBackend. This is great, but because MCContext couldn't easily be threaded through to the adjustFixupValue helper function from its usual callsite (applyFixup), these backends ended up adding an `MCContext*` argument and adding another call to applyFixup to processFixupValue. If we just add an MCContext parameter to applyFixup, this is unnecessary, and even better - applyFixup can take a reference to MCContext rather than a potentially null pointer.

See https://reviews.llvm.org/D18402 for some relevant discussion.


https://reviews.llvm.org/D30264

Files:
  include/llvm/MC/MCAsmBackend.h
  lib/MC/MCAssembler.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp
  lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
  lib/Target/ARM/MCTargetDesc/ARMAsmBackend.h
  lib/Target/ARM/MCTargetDesc/ARMELFObjectWriter.cpp
  lib/Target/BPF/MCTargetDesc/BPFAsmBackend.cpp
  lib/Target/Hexagon/MCTargetDesc/HexagonAsmBackend.cpp
  lib/Target/Lanai/MCTargetDesc/LanaiAsmBackend.cpp
  lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
  lib/Target/Mips/MCTargetDesc/MipsAsmBackend.h
  lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp
  lib/Target/Sparc/MCTargetDesc/SparcAsmBackend.cpp
  lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmBackend.cpp
  lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
  test/MC/ARM/quad-relocation.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30264.89389.patch
Type: text/x-patch
Size: 36668 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170222/bf969667/attachment-0001.bin>