[PATCH] D30086: Add generic IR vector reductions

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 10:29:03 PST 2017

mkuper added a comment.

In https://reviews.llvm.org/D30086#683340, @aemerson wrote:

> Ok, so for now I'll make the changes to address the review comments but I won't be moving to a late lowering solution (which I think is more preferable but if these are experimental then we can't do that).

I think we need late lowering support, in addition to the opt-in, even if the intrinsics are experimental. Without it, it's kind of hard to "experiment" with them. :-)
E.g. we'd like to enable them on x86, and see what breaks.



More information about the llvm-commits mailing list