[PATCH] D30187: [ELF] - Improve diagnostic messages for move location counter errors.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 10:13:15 PST 2017


ruiu added inline comments.


================
Comment at: lld/trunk/ELF/LinkerScript.h:109
+
+  std::string Location;
 };
----------------
grimar wrote:
> ruiu wrote:
> > This needs a comment.
> I wonder if it worth to make Location a member of BaseCommand.
> Since we also use it in OutputSectionCommand.
> At the same time other commands seems do not need it.
That's a good point. I guess it might make sense to move it to BaseCommand because basically we need debug info for all commands to print out user-friendly error messages.


Repository:
  rL LLVM

https://reviews.llvm.org/D30187





More information about the llvm-commits mailing list