[PATCH] D30254: Remove sometimes faulty rewrite of memcpy in instcombine.

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 06:32:03 PST 2017


uabelho created this revision.

Solves PR 31990.

The bad rewrite could replace a memcpy of one word with
 store i4 -1
while it should actually be
 store i8 -1

Hopefully opt and llc has improved enough so the original optimization
done by the code isn't needed anymore.

One already existing testcase is affected. It originally tested that
the memcpy was replaced with
 load double
but since we now remove that rewrite it will be
 load i64
instead.

Patch suggestion by Eli Friedman.


https://reviews.llvm.org/D30254

Files:
  lib/Transforms/InstCombine/InstCombineCalls.cpp
  test/Transforms/InstCombine/memcpy-to-load.ll
  test/Transforms/InstCombine/pr31990_wrong_memcpy.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30254.89354.patch
Type: text/x-patch
Size: 5573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170222/b34e4a2e/attachment.bin>


More information about the llvm-commits mailing list