[PATCH] D29958: AMDGPU : Replace FMAD with FMA when denormals are enabled.

Wei Ding via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 15:57:30 PST 2017


wdng marked an inline comment as done.
wdng added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:1297
+  unsigned OpCode = Subtarget->hasFP32Denormals() ? 
+                    (unsigned)AMDGPUISD::FMAD_FTZ : 
+                    (unsigned)ISD::FMAD;
----------------
arsenm wrote:
> The casts are unnecessary
If cast is removed, there will be a "warning: enumeral mismatch in conditional expression: ‘llvm::AMDGPUISD::NodeType’ vs ‘llvm::ISD::NodeType’", shall we still remove it?


Repository:
  rL LLVM

https://reviews.llvm.org/D29958





More information about the llvm-commits mailing list