[PATCH] D30224: [ELF] Insert linkerscript symbols directly into symbol table

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/linkerscript/Inputs/lazy-symbols.s:3-7
+ .long .Linfo_string
+
+.section .debug_str,"MS", at progbits,1
+.Linfo_string:
+  .asciz "foo"
----------------
You don't need to make symbol` foo` have real contents, so you can remove this.


================
Comment at: test/ELF/linkerscript/lazy-symbols.s:2
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %S/Inputs/lazy-symbols.s -o %t1
+# RUN: llvm-ar rcs %tar %t1
----------------
Please add a comment to say that this test is to make sure that a linker script can define a symbol which have the same name as a lazy symbol.


Repository:
  rL LLVM

https://reviews.llvm.org/D30224