[PATCH] D30124: [ARM] Fix insert point for store rescheduling.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 13:31:38 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D30124#682736, @MatzeB wrote:

> What I wanted to say is that the subtarget feature APIs/tablegen do not allow you to do something like `llc -mattr=MyLimit=8` yet.


Right, I'm not sure we want this at all, ever, for this particular choice.

I'm not even sure we need different values, but since we should be moving magic numbers to descriptive constants, there seems like a better place than most to put it, even if all targets use the same.


Repository:
  rL LLVM

https://reviews.llvm.org/D30124





More information about the llvm-commits mailing list