[PATCH] D30124: [ARM] Fix insert point for store rescheduling.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 13:22:45 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D30124#682714, @MatzeB wrote:

> The change itself looks straightforward.
>  Having the magic number `8` tunable would indeed be nice, unfortunately target features are only boolean (enable or disabled) today; While I would applaud everyone improving the targetfeature system to support arbitrary integer values, I don't think we need to block this bugfix for it esp. since the magic number already existed in the code.


We already have integer values attributed to sub-architectures. But I'm not fussed about this in particular, just thought it would be a good and easy place to already fix the fixme.


Repository:
  rL LLVM

https://reviews.llvm.org/D30124





More information about the llvm-commits mailing list