[PATCH] D30207: [ARM] Fix constant islands pass.

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Ouch, ok, that's not good.

The fix looks obvious, and the test is large, but given the intricate nature of the problem (`push lr` only happens unnaturally inside the compiler), I'm not sure what to recommend other than "go for it".

If you find a better reproducer, please update the test. Otherwise, it shouldn't matter too much.

cheers,
--renato


https://reviews.llvm.org/D30207