[PATCH] D30206: [DWARF5] Emit new unit header

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 09:14:32 PST 2017

aprantl added a comment.

Thanks for getting this started!

Comment at: include/llvm/Support/Dwarf.h:308
+/// Constants for unit types in DWARF v5.
+enum UnitType : unsigned char {
We might want to unify the spelling of DWARF v5 vs. DWARF5

Comment at: include/llvm/Support/Dwarf.h:316
 // Constants for the DWARF5 Accelerator Table Proposal
 enum AcceleratorTable {
as seen here :-)

Comment at: lib/DebugInfo/DWARF/DWARFUnit.cpp:99
+    AddrSize = debug_info.getU8(offset_ptr);
+  }
   if (IndexEntry) {
This should probably be tested by a llvm-dwarfdump test?


More information about the llvm-commits mailing list