[PATCH] D30187: [ELF] - Improve diagnostic messages for move location counter errors.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 06:41:30 PST 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
> Index: test/ELF/linkerscript/out-of-order.s
> ===================================================================
> --- test/ELF/linkerscript/out-of-order.s
> +++ test/ELF/linkerscript/out-of-order.s
> @@ -3,7 +3,7 @@
>  # RUN: echo "SECTIONS { .data 0x4000 : { *(.data) } .text 0x2000 : { *(.text) } }" > %t.script
>  # RUN: not ld.lld -o %t.so --script %t.script %t.o -shared 2>&1 | FileCheck %s
>  
> -# CHECK:  error: unable to move location counter backward
> +# CHECK:  error: {{.*}}.script:1: unable to move location counter backward


Add a newline to the scripts to show that it is reporting the correct
line.

LGTM with that.

Cheers,
Rafael


More information about the llvm-commits mailing list