[PATCH] D30188: [ELF] - Do not segfault when using --gc-sections with linker script

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/ELF/linkerscript/sections-gc.s:7
+
+# CHECK:      Sections:
+# CHECK-NEXT: Idx Name      Size
----------------
grimar wrote:
> jhenderson wrote:
> > Do we really need these first two CHECKs?
> Thats for self-documenting the test.
> It shows we check Sections and that "00000001" is a Size field. 
> I am checking a size to show that one of sections was collected.
I see, that makes sense. In that case, can we drop the "Idx" part of the string, since we don't check the section index? It would also make things line up nicer (i.e. ".text" appears underneath "Name").


https://reviews.llvm.org/D30188