[PATCH] D30178: Do not leak OpenedHandles

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a subscriber: marsupial.
vsk added inline comments.


================
Comment at: lib/Support/DynamicLibrary.cpp:72
   if (!OpenedHandles)
     OpenedHandles = new DenseSet<void *>();
 
----------------
I'd expect all initializations of OpenedHandles to be unnecessary after your change.


================
Comment at: lib/Support/Windows/DynamicLibrary.inc:12
 //
+// FIXME: This file leaks OpenedHandles!
+//
----------------
@marsupial do you think it'd be a good idea to fix up the Windows version of OpenedHandles here, or would you rather do it in your patch?


Repository:
  rL LLVM

https://reviews.llvm.org/D30178