[PATCH] D28249: Improve scheduling with branch coalescing

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 10:03:24 PST 2017


lei marked 5 inline comments as done.
lei added inline comments.


================
Comment at: lib/CodeGen/BranchCoalescing.cpp:663-666
+  // Merge FallThroughBlock
+  // Move any PHIs down to the branch-taken block
+
+  // Not necessary to merge the fall-through blocks, they should be empty!
----------------
echristo wrote:
> This set of comments is very confusing.
okay


https://reviews.llvm.org/D28249





More information about the llvm-commits mailing list