[PATCH] D28249: Improve scheduling with branch coalescing

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 08:33:25 PST 2017


lei marked 5 inline comments as done.
lei added inline comments.


================
Comment at: lib/CodeGen/BranchCoalescing.cpp:363
+/// refer to the new block. PHI instructions in SourceMBB are placed at the
+/// beginning of TargetMBB, before existing PHI instructions.
+///
----------------
echristo wrote:
> Could use an explanation of why - it confused Nemanja at first and could confuse others.
Sine PHI node ordering can not be assumed, it doesn't really matter where we place the PHI instructions.  Will update comment to reflect this.


https://reviews.llvm.org/D28249





More information about the llvm-commits mailing list