[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D29489#681552, @jonpa wrote:

> Ooops!  Fixed now, hopefully.
>
> However, it seems that the handling for VECTOR_SHUFFLE is actually not needed anymore. My only guess is that this is due to some other recent change. This would actually be removed at least from my first commit(s), then.


Not needed possibly due to https://reviews.llvm.org/D29454 - please drop it then as its almost certainly not being tested properly.

> Again, are you fine with handling all these cases early per my previous comment?

Yes if promotion can stop all of these cases then its probably a better place to handle it.


https://reviews.llvm.org/D29489