[PATCH] D29578: Propagate debug info for Phi node in SSAUpdater

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 02:29:51 PST 2017


samparker added a comment.

Hi Daniel,

Thanks for your comments. I had hoped that performing this in the SSA updater would prevent this bug from appearing in other passes that update/replace the Phi nodes. Do you think there's a way to achieve this in a manner that isn't local to loop rotate? And by stashing and replacing, will getMetadata and setMetadata be okay for this purpose? Would I still not have to update the debug value to reflect the value of the new phi node?

Thanks again,
sam


https://reviews.llvm.org/D29578





More information about the llvm-commits mailing list