[PATCH] D28593: Update loop branch_weight metadata after loop rotation.

Xin Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 19 18:58:57 PST 2017


trentxintong updated this revision to Diff 89076.
trentxintong added a comment.

Address davidxl's comments.

I reworked how !prof metadata is computed after loop rotation.

There is one test case in peel-loop-pgo.ll. thats because I corrected how
estimated loop trip count is computed. I think its a good idea to fix loop rotation
metadada and getEstimatedTripCount together as getEstimatedTripCount uses 
!prof metadata which is computed in a new way.  However, the drawback is that
i need to modify a test case unrelated to loop rotation.


https://reviews.llvm.org/D28593

Files:
  lib/Transforms/Scalar/LoopRotation.cpp
  lib/Transforms/Utils/LoopUtils.cpp
  test/Transforms/LoopRotate/loop-rotate-pgo.ll
  test/Transforms/LoopUnroll/peel-loop-pgo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28593.89076.patch
Type: text/x-patch
Size: 18070 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170220/274624e3/attachment.bin>


More information about the llvm-commits mailing list