[PATCH] D29705: Fix PR 24415 (at least), by making our post-dominator tree behavior sane.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 19 16:36:29 PST 2017


dberlin marked 6 inline comments as done.
dberlin added a comment.

I have updated all tests.
The region ones were particularly nutso before (IHMO), and now look sane.

there is one failure in ADCE, because previously postdom gave it an empty tree, and now gives it a real tree.
It expects that all not-reachable-from-exit nodes will not have a dom tree node, which is not correct.
It also assumes it will be able to find a safe place to redirect an edge that  still exits the function, which is also not correct.
Fixes for both coming.
Then i am going to look at the two structurize cfg failures.


https://reviews.llvm.org/D29705





More information about the llvm-commits mailing list