[PATCH] D30086: Add generic IR vector reductions

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 19 13:47:32 PST 2017


Oh, didn't realize we had this already! Thanks.
Then, yes, sure.

On Feb 19, 2017 13:39, "Mehdi AMINI via Phabricator" <
reviews at reviews.llvm.org> wrote:

> mehdi_amini added inline comments.
>
>
> ================
> Comment at: docs/LangRef.rst:11655
> +reduction of a vector, returning the result as a scalar. The return type
> matches
> +the element-type of the vector input.
> +
> ----------------
> mkuper wrote:
> > mehdi_amini wrote:
> > > delena wrote:
> > > > mehdi_amini wrote:
> > > > > I think it'd be important to clarify the ordering: do we require a
> "fast" FMF to change it? If not, why?
> > > > I think that in the case of FP operations we need two intrinsics -
> "ordered" and "fast".
> > > Why don't reusing the existing FMF? The intrinsic without FMF would be
> equivalent to "ordered" and the "fast" FMF flag would allow any ordering.
> > I don't think we can currently attach FMF to CallInsts.
> We do actually: http://lists.llvm.org/pipermail/llvm-commits/Week-
> of-Mon-20151214/319516.html
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D30086
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170219/5170b02e/attachment.html>


More information about the llvm-commits mailing list