[PATCH] D30154: MemorySSA: Add support for renaming uses in the updater.

[Piotr Padlewski via Phabricator via llvm-commits]

Prazek added inline comments.


================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:692
+                  bool SkipVisited = false, bool RenameAllUses = false) {
+    renamePass(DT->getNode(BB), IncomingVal, Visited, true, true);
+  }
----------------
why 2 last params are not used?


================
Comment at: unittests/Transforms/Utils/MemorySSA.cpp:186
       SecondEntryStore, nullptr, Entry, MemorySSA::End);
-  Updater.insertDef(cast<MemoryDef>(SecondEntryStoreAccess));
+  Updater.insertDef(cast<MemoryDef>(SecondEntryStoreAccess), true);
   // and make sure the phi below it got updated, despite being blocks away
----------------
Shouldn't it have some EXPECTs checking that renaming happened? 


https://reviews.llvm.org/D30154