[llvm] r294919 - testing

[Davide Italiano via llvm-commits]

I think this was reverted shortly after.

On Sun, Feb 19, 2017 at 12:36 AM, Sanjoy Das via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Did you forget the commit message here?
>
> -- Sanjoy
>
> On 2/12/17, 2:02 PM, Daniel Berlin via llvm-commits wrote:
>>
>> Author: dannyb
>> Date: Sun Feb 12 16:02:20 2017
>> New Revision: 294919
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=294919&view=rev
>> Log:
>> testing
>>
>> Modified:
>>      llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
>>
>> Modified: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=294919&r1=294918&r2=294919&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp (original)
>> +++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp Sun Feb 12 16:02:20 2017
>> @@ -571,7 +571,7 @@ const Expression *NewGVN::createExpressi
>>       // numbers.  Since all commutative instructions have two operands it
>> is more
>>       // efficient to sort by hand rather than using, say, std::sort.
>>       assert(I->getNumOperands() == 2&&  "Unsupported commutative
>> instruction!");
>> -    if (E->getOperand(0)>  E->getOperand(1))
>> +    if (shouldSwapOperands(E->getOperand(0), E->getOperand(1)))
>>         E->swapOperands(0, 1);
>>     }
>>
>> @@ -2425,6 +2425,7 @@ bool NewGVN::eliminateInstructions(Funct
>>   // we will simplify an operation with all constants so that it doesn't
>> matter
>>   // what order they appear in.
>>   unsigned int NewGVN::getRank(const Value *V) const {
>> +  assert(V&&  "What?");
>>     if (isa<Constant>(V))
>>       return 0;
>>     else if (auto *A = dyn_cast<Argument>(V))
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare