[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 18 11:29:57 PST 2017


kzhuravl added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:715
+  /// pointer or reference type respectively.
+  Optional<unsigned> AddressSpace;
+
----------------
Since this is a mapped address space and not LLVM address space (in our case it is Target-specific DWARF Address Space), the name should reflect that.

We were thinking of prefixing it with "DI", but not sure what the policy is here. Seems like types are prefixed with "DI".

Would there be any objections if we rename it to DIAddressSpace?


https://reviews.llvm.org/D29670





More information about the llvm-commits mailing list